From: Miklos Szeredi Date: Mon, 7 Apr 2014 22:37:51 +0000 (-0700) Subject: mm: remove unused arg of set_page_dirty_balance() X-Git-Tag: v3.2.67~59 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=57b31943b128c88c591005f122005c033e5d6409;p=thirdparty%2Fkernel%2Fstable.git mm: remove unused arg of set_page_dirty_balance() commit ed6d7c8e578331cad594ee70d60e2e146b5dce7b upstream. There's only one caller of set_page_dirty_balance() and that will call it with page_mkwrite == 0. The page_mkwrite argument was unused since commit b827e496c893 "mm: close page_mkwrite races". Signed-off-by: Miklos Szeredi Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds [bwh: Backported to 3.2: adjust context] Signed-off-by: Ben Hutchings --- diff --git a/include/linux/writeback.h b/include/linux/writeback.h index 7e85d454c163e..bd214aebf86dd 100644 --- a/include/linux/writeback.h +++ b/include/linux/writeback.h @@ -190,7 +190,7 @@ int write_cache_pages(struct address_space *mapping, struct writeback_control *wbc, writepage_t writepage, void *data); int do_writepages(struct address_space *mapping, struct writeback_control *wbc); -void set_page_dirty_balance(struct page *page, int page_mkwrite); +void set_page_dirty_balance(struct page *page); void writeback_set_ratelimit(void); void tag_pages_for_writeback(struct address_space *mapping, pgoff_t start, pgoff_t end); diff --git a/mm/memory.c b/mm/memory.c index e714317fd5131..fb55a9755a02f 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2671,7 +2671,7 @@ reuse: */ if (!page_mkwrite) { wait_on_page_locked(dirty_page); - set_page_dirty_balance(dirty_page, page_mkwrite); + set_page_dirty_balance(dirty_page); } put_page(dirty_page); if (page_mkwrite) { diff --git a/mm/page-writeback.c b/mm/page-writeback.c index d2ac057008f2a..cab99e82b8302 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1202,9 +1202,9 @@ pause: bdi_start_background_writeback(bdi); } -void set_page_dirty_balance(struct page *page, int page_mkwrite) +void set_page_dirty_balance(struct page *page) { - if (set_page_dirty(page) || page_mkwrite) { + if (set_page_dirty(page)) { struct address_space *mapping = page_mapping(page); if (mapping)