From: Jiri Denemark <jdenemar@redhat.com>
Date: Tue, 12 Mar 2013 08:10:41 +0000 (+0100)
Subject: qemu: Avoid NULL dereference in qemuSharedDiskEntryFree
X-Git-Tag: v1.0.4-rc1~121
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=57bb725acaf3f04f5fe4570d811a2ca840a4960c;p=thirdparty%2Flibvirt.git

qemu: Avoid NULL dereference in qemuSharedDiskEntryFree

At least one caller may call qemuSharedDiskEntryFree with NULL as the
first argument. Let's make the function similar to other *Free functions
and do nothing in such case.
---

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 3ef3499bbd..24086105f7 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -1045,6 +1045,9 @@ qemuSharedDiskEntryFree(void *payload, const void *name ATTRIBUTE_UNUSED)
     qemuSharedDiskEntryPtr entry = payload;
     size_t i;
 
+    if (!entry)
+        return;
+
     for (i = 0; i < entry->ref; i++) {
         VIR_FREE(entry->domains[i]);
     }