From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Date: Thu, 27 Jun 2024 11:15:31 +0000 (+0200)
Subject: Revert "media: stm32: dcmipp: correct error handling in dcmipp_create_subdevs"
X-Git-Tag: v6.11-rc1~142^2~58
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=57dd8f2f77bc85374fc06962110cad0259a1a495;p=thirdparty%2Fkernel%2Flinux.git

Revert "media: stm32: dcmipp: correct error handling in dcmipp_create_subdevs"

This reverts commit 77d32b7e2a7b2e5389b67363d25371b4b8cad140.

This patch is obviously wrong (causes array accesses at index -1),
and I caught that just too late.
---

diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
index 4924ee36cfdaf..4acc3b90d03aa 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
@@ -202,7 +202,7 @@ static int dcmipp_create_subdevs(struct dcmipp_device *dcmipp)
 	return 0;
 
 err_init_entity:
-	while (i-- > 0)
+	while (i > 0)
 		dcmipp->pipe_cfg->ents[i - 1].release(dcmipp->entity[i - 1]);
 	return ret;
 }