From: Mark Andrews Date: Mon, 18 Jul 2022 07:39:12 +0000 (+1000) Subject: Remove dead code X-Git-Tag: v9.19.5~13^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5805457d9d9e4188bfa7c7a2b2c5b42f1ef255dc;p=thirdparty%2Fbind9.git Remove dead code *** CID 352816: Control flow issues (DEADCODE) /lib/ns/query.c: 8443 in query_dns64() 8437 cleanup: 8438 if (buffer != NULL) { 8439 isc_buffer_free(&buffer); 8440 } 8441 8442 if (dns64_rdata != NULL) { >>> CID 352816: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "dns_message_puttemprdata(cl...". 8443 dns_message_puttemprdata(client->message, &dns64_rdata); 8444 } 8445 8446 if (dns64_rdataset != NULL) { 8447 dns_message_puttemprdataset(client->message, &dns64_rdataset); 8448 } --- diff --git a/lib/ns/query.c b/lib/ns/query.c index ea676dd537e..93d2d6c353d 100644 --- a/lib/ns/query.c +++ b/lib/ns/query.c @@ -8324,10 +8324,6 @@ cleanup: isc_buffer_free(&buffer); } - if (dns64_rdata != NULL) { - dns_message_puttemprdata(client->message, &dns64_rdata); - } - if (dns64_rdataset != NULL) { dns_message_puttemprdataset(client->message, &dns64_rdataset); }