From: Martin Liska Date: Fri, 5 Nov 2021 15:50:06 +0000 (+0100) Subject: gcov-profile: Fix -fcompare-debug with -fprofile-generate [PR100520] X-Git-Tag: releases/gcc-11.3.0~672 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=580d66f5a0bdcd88dcdab2d4ace3bbbaae121af3;p=thirdparty%2Fgcc.git gcov-profile: Fix -fcompare-debug with -fprofile-generate [PR100520] PR gcov-profile/100520 gcc/ChangeLog: * coverage.c (coverage_compute_profile_id): Strip .gk when compare debug is used. * system.h (endswith): New function. gcc/testsuite/ChangeLog: * gcc.dg/pr100520.c: New test. (cherry picked from commit 7553bd35c876efaf8ab0b6661a6102822b99e6e3) --- diff --git a/gcc/coverage.c b/gcc/coverage.c index 9b98e0173abe..17d1beeca3da 100644 --- a/gcc/coverage.c +++ b/gcc/coverage.c @@ -576,8 +576,11 @@ coverage_compute_profile_id (struct cgraph_node *n) if (!use_name_only && first_global_object_name) chksum = coverage_checksum_string (chksum, first_global_object_name); - chksum = coverage_checksum_string - (chksum, aux_base_name); + char *base_name = xstrdup (aux_base_name); + if (endswith (base_name, ".gk")) + base_name[strlen (base_name) - 3] = '\0'; + chksum = coverage_checksum_string (chksum, base_name); + free (base_name); } /* Non-negative integers are hopefully small enough to fit in all targets. diff --git a/gcc/system.h b/gcc/system.h index a3f5948aaeec..b13e9429577a 100644 --- a/gcc/system.h +++ b/gcc/system.h @@ -1291,4 +1291,17 @@ void gcc_stablesort (void *, size_t, size_t, #define NULL nullptr #endif +/* Return true if STR string ends with SUFFIX. */ + +static inline bool +endswith (const char *str, const char *suffix) +{ + size_t str_len = strlen (str); + size_t suffix_len = strlen (suffix); + if (str_len < suffix_len) + return false; + + return memcmp (str + str_len - suffix_len, suffix, suffix_len) == 0; +} + #endif /* ! GCC_SYSTEM_H */ diff --git a/gcc/testsuite/gcc.dg/pr100520.c b/gcc/testsuite/gcc.dg/pr100520.c new file mode 100644 index 000000000000..60f79c2b8885 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr100520.c @@ -0,0 +1,5 @@ +/* PR gcov-profile/100520 */ +/* { dg-do compile } */ +/* { dg-options "-fcompare-debug -fprofile-generate" } */ + +static int f() {}