From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Thu, 7 Dec 2023 17:57:55 +0000 (+0000)
Subject: Remove broken and disabled icpPktDump() (#1616)
X-Git-Tag: SQUID_7_0_1~263
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=581447929a033189119e05828aed7cfb42447825;p=thirdparty%2Fsquid.git

Remove broken and disabled icpPktDump() (#1616)
---

diff --git a/src/icp_v2.cc b/src/icp_v2.cc
index 6f7e7c857b..1b901f6172 100644
--- a/src/icp_v2.cc
+++ b/src/icp_v2.cc
@@ -604,24 +604,6 @@ icpHandleIcpV2(int fd, Ip::Address &from, char *buf, int len)
     }
 }
 
-#ifdef ICP_PKT_DUMP
-static void
-icpPktDump(icp_common_t * pkt)
-{
-    Ip::Address a;
-
-    debugs(12, 9, "opcode:     " << std::setw(3) << pkt->opcode  << " " << icp_opcode_str[pkt->opcode]);
-    debugs(12, 9, "version: "<< std::left << std::setw(8) << pkt->version);
-    debugs(12, 9, "length:  "<< std::left << std::setw(8) << ntohs(pkt->length));
-    debugs(12, 9, "reqnum:  "<< std::left << std::setw(8) << ntohl(pkt->reqnum));
-    debugs(12, 9, "flags:   "<< std::left << std::hex << std::setw(8) << ntohl(pkt->flags));
-    a = (struct in_addr)pkt->shostid;
-    debugs(12, 9, "shostid: " << a );
-    debugs(12, 9, "payload: " << (char *) pkt + sizeof(icp_common_t));
-}
-
-#endif
-
 void
 icpHandleUdp(int sock, void *)
 {
@@ -668,11 +650,6 @@ icpHandleUdp(int sock, void *)
         debugs(12, 4, "icpHandleUdp: FD " << sock << ": received " <<
                (unsigned long int)len << " bytes from " << from);
 
-#ifdef ICP_PACKET_DUMP
-
-        icpPktDump(buf);
-#endif
-
         if ((size_t) len < sizeof(icp_common_t)) {
             debugs(12, 4, "icpHandleUdp: Ignoring too-small UDP packet");
             break;