From: Douglas Bagnall Date: Wed, 19 May 2021 02:39:00 +0000 (+0000) Subject: pytest:dns_base: make_txt_update can set arbitrary TTL X-Git-Tag: tevent-0.11.0~394 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=581d7a528e86a8354ec20243deb2c436d9cf861d;p=thirdparty%2Fsamba.git pytest:dns_base: make_txt_update can set arbitrary TTL Also, improve a variable name. Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- diff --git a/python/samba/tests/dns_base.py b/python/samba/tests/dns_base.py index e522120b932..b92371e9cdd 100644 --- a/python/samba/tests/dns_base.py +++ b/python/samba/tests/dns_base.py @@ -165,11 +165,11 @@ class DNSTest(TestCaseInTempDir): self.assertEqual(my_packet, recv_packet[2:]) return (response, recv_packet[2:]) - def make_txt_update(self, prefix, txt_array, domain=None): + def make_txt_update(self, prefix, txt_array, zone=None, ttl=900): p = self.make_name_packet(dns.DNS_OPCODE_UPDATE) updates = [] - name = domain or self.get_dns_domain() + name = zone or self.get_dns_domain() u = self.make_name_question(name, dns.DNS_QTYPE_SOA, dns.DNS_QCLASS_IN) updates.append(u) self.finish_name_packet(p, updates) @@ -179,7 +179,7 @@ class DNSTest(TestCaseInTempDir): r.name = "%s.%s" % (prefix, name) r.rr_type = dns.DNS_QTYPE_TXT r.rr_class = dns.DNS_QCLASS_IN - r.ttl = 900 + r.ttl = ttl r.length = 0xffff rdata = self.make_txt_record(txt_array) r.rdata = rdata