From: Paul Floyd <pjfloyd@wanadoo.fr>
Date: Wed, 25 Jan 2023 07:31:09 +0000 (+0100)
Subject: FreeBSD: update comment about __sysctlbyname and kern.proc.pathname
X-Git-Tag: VALGRIND_3_21_0~203
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5830ece5cdfd71cb7a7b537b5b58c9a9858a78a3;p=thirdparty%2Fvalgrind.git

FreeBSD: update comment about __sysctlbyname and kern.proc.pathname
---

diff --git a/coregrind/m_syswrap/syswrap-freebsd.c b/coregrind/m_syswrap/syswrap-freebsd.c
index 401a7ba8ee..13d3b6bf25 100644
--- a/coregrind/m_syswrap/syswrap-freebsd.c
+++ b/coregrind/m_syswrap/syswrap-freebsd.c
@@ -6468,8 +6468,9 @@ PRE(sys___sysctlbyname)
       SET_STATUS_Success(0);
    }
 
-   // @todo PJF kern.proc.pathname
-   // how is that done? jusr a pid or -1 in the string?
+   // kern.proc.pathname doesn't seem to be handled
+   // makes sense as the pid is variable and using
+   // a MIB is easier than generating a string
 
    // read number of ints specified in ARG2 from mem pointed to by ARG1
    PRE_MEM_READ("__sysctlbyname(name)", (Addr)ARG1, ARG2 * sizeof(int));