From: Zhao Liu Date: Tue, 18 Nov 2025 08:08:37 +0000 (+0800) Subject: i386/cpu: Drop incorrect comment for CPUID 0x1E X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5839e9a1ccc956e75b19ee67821f8816907bbbd9;p=thirdparty%2Fqemu.git i386/cpu: Drop incorrect comment for CPUID 0x1E The information (tmul_maxk and tmul_maxn) in CPUID 0x1E.0x0.EBX is defined for architecture, not for SPR. This is to say, these "hardcoded" values won't change in future. If the TMUL component needs to be extended for new palettes, there'll likely be the new TMUL instructions, or new types of AMX instructions that are _parallel_ to TMUL that operate in particular palettes, instead of changing current tmul_maxk and tmul_maxn fields in CPUID 0x1E.0x0.EBX. Furthermore, the previous attempt [*] to make the 0x1E.0x0.EBX fields user-configurable is incorrect and unnecessary. Therefore, drop the incorrect and misleading comment. [*]: https://lore.kernel.org/qemu-devel/20230106083826.5384-2-lei4.wang@intel.com/ Signed-off-by: Zhao Liu Reviewed-by: Xiaoyao Li Link: https://lore.kernel.org/r/20251118080837.837505-3-zhao1.liu@intel.com Signed-off-by: Paolo Bonzini --- diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 4421c45849..67769200d0 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -8403,7 +8403,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count, break; } case 0x1E: { - /* AMX TMUL, for now hardcoded for Sapphire Rapids */ + /* AMX TMUL */ *eax = 0; *ebx = 0; *ecx = 0;