From: Michal Simek Date: Thu, 2 Apr 2026 15:36:58 +0000 (+0200) Subject: event: Check return value from event_notify_null() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=583efb5040587f06bab5f5d3eb321186c3a39fe4;p=thirdparty%2Fu-boot.git event: Check return value from event_notify_null() event_notify_null() returns int but its return value is not checked in run_main_loop() and in fwu_mdata tests. Add proper error checking to all unchecked call sites. Signed-off-by: Michal Simek Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- diff --git a/common/board_r.c b/common/board_r.c index 8cf0e14679c..5d37345ca09 100644 --- a/common/board_r.c +++ b/common/board_r.c @@ -569,11 +569,15 @@ static int dm_announce(void) static int run_main_loop(void) { + int ret; + #ifdef CONFIG_SANDBOX sandbox_main_loop_init(); #endif - event_notify_null(EVT_MAIN_LOOP); + ret = event_notify_null(EVT_MAIN_LOOP); + if (ret) + return ret; /* main_loop() can return to retry autoboot, if so just run it again */ for (;;) diff --git a/test/dm/fwu_mdata.c b/test/dm/fwu_mdata.c index b7680632f95..643b647af0a 100644 --- a/test/dm/fwu_mdata.c +++ b/test/dm/fwu_mdata.c @@ -100,7 +100,7 @@ static int dm_test_fwu_mdata_read(struct unit_test_state *uts) * Trigger lib/fwu_updates/fwu.c fwu_boottime_checks() * to populate g_dev global pointer in that library. */ - event_notify_null(EVT_MAIN_LOOP); + ut_assertok(event_notify_null(EVT_MAIN_LOOP)); ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev)); ut_assertok(fwu_init()); @@ -127,7 +127,7 @@ static int dm_test_fwu_mdata_write(struct unit_test_state *uts) * Trigger lib/fwu_updates/fwu.c fwu_boottime_checks() * to populate g_dev global pointer in that library. */ - event_notify_null(EVT_MAIN_LOOP); + ut_assertok(event_notify_null(EVT_MAIN_LOOP)); ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev));