From: Gary V. Vaughan Date: Mon, 30 Aug 2004 20:44:11 +0000 (+0000) Subject: * config/ltmain.in: Double quote even $# for the sake of sh.test. X-Git-Tag: release-1-9d~91 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=584717dd07cb14ac116320176403e37d4f0b5f83;p=thirdparty%2Flibtool.git * config/ltmain.in: Double quote even $# for the sake of sh.test. (exec_cmd): Be careful about "`"foo"`" quoting, even in comments to avoid triggering the tests in sh.test. --- diff --git a/ChangeLog b/ChangeLog index 23ff3e865..5f20e2707 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2004-08-30 Gary V. Vaughan + * config/ltmain.in: Double quote even $# for the sake of sh.test. + (exec_cmd): Be careful about "`\"foo\"`" quoting, even in comments + to avoid triggering the tests in sh.test. + * configure.ac: Because of the way the autoconf C++ testing works, we need to call the C test first to work in an environment that has no C++ compiler. diff --git a/config/ltmain.in b/config/ltmain.in index fb207ca01..ba9c09b57 100644 --- a/config/ltmain.in +++ b/config/ltmain.in @@ -370,8 +370,8 @@ func_enable_tag () # Evaluate the configuration. Be careful to quote the path # and the sed script, to avoid splitting on whitespace, but - # also don't use non-portable "`\"foo\"`", so we have to do - # it in 2 steps: + # also don't use non-portable quotes within backquotes within + # quotes we have to do it in 2 steps: extractedcf=`$SED -n -e "$sed_extractcf" < "$progpath"` eval "$extractedcf" else @@ -610,7 +610,7 @@ Otherwise, only FILE itself is deleted using RM." set -x ;; - --dlopen) test $# -eq 0 && func_missing_arg "$opt" && break + --dlopen) test "$#" -eq 0 && func_missing_arg "$opt" && break execute_dlfiles="$execute_dlfiles $1" ;; @@ -618,7 +618,7 @@ Otherwise, only FILE itself is deleted using RM." --features) func_features ;; --finish) mode="finish" ;; - --mode) test $# -eq 0 && func_missing_arg "$opt" && break + --mode) test "$#" -eq 0 && func_missing_arg "$opt" && break case $1 in # Valid mode arguments: clean) ;; @@ -648,7 +648,7 @@ Otherwise, only FILE itself is deleted using RM." show=: ;; - --tag) test $# -eq 0 && func_missing_arg "$opt" && break + --tag) test "$#" -eq 0 && func_missing_arg "$opt" && break preserve_args="$preserve_args $opt $1" func_enable_tag "$1" # tagname is set here shift