From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 6 Jan 2009 20:50:51 +0000 (+0000)
Subject: Note a problem in the interface tor_addr_to_sockaddr.
X-Git-Tag: tor-0.2.1.11-alpha~46
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=585d4a12b50aa0151411c777a6c7d266d71fb46f;p=thirdparty%2Ftor.git

Note a problem in the interface tor_addr_to_sockaddr.

svn:r17982
---

diff --git a/src/common/address.c b/src/common/address.c
index 7b122e3f24..0e92b71f91 100644
--- a/src/common/address.c
+++ b/src/common/address.c
@@ -53,6 +53,8 @@
  * socklen object in *<b>sa_out</b> of object size <b>len</b>.  If not enough
  * room is free, or on error, return -1.  Else return the length of the
  * sockaddr. */
+/* XXXX021 This returns socklen_t.  socklen_t is sometimes unsigned.  This
+ *   function claims to return -1 sometimes.  Problematic! */
 socklen_t
 tor_addr_to_sockaddr(const tor_addr_t *a,
                      uint16_t port,