From: Martin Schwenke <martin@meltin.net>
Date: Thu, 6 Feb 2020 06:57:32 +0000 (+1100)
Subject: selftest: Fix an uninitialised variable warning.
X-Git-Tag: ldb-2.1.1~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=586189ab69850dc292cea874f6a115851323a57c;p=thirdparty%2Fsamba.git

selftest: Fix an uninitialised variable warning.

If $nmbd is not "yes" then this can result in a warning.

Introduced in commit 676261fa08273114b888bb46f65de3de091b615b.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index ad184684820..9e86247ceab 100755
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -2591,8 +2591,8 @@ sub wait_for_start($$$$$)
 	    $cmd .= Samba::bindir_path($self, "wbinfo") . " --ping-dc";
 
 	    do {
+		$ret = system($cmd);
 		if ($ret != 0) {
-		    $ret = system($cmd);
 		    sleep(1);
 		}
 		$count++;