From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Date: Mon, 10 Dec 2018 20:52:23 +0000 (-0600)
Subject: benchtests: keep comparing even if function timings do not match
X-Git-Tag: glibc-2.29~208
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=587426d499e6ac40dafd9a19dcd12cb6af93f5fc;p=thirdparty%2Fglibc.git

benchtests: keep comparing even if function timings do not match

Allows other functions to be processed, making the script a bit more fault
tolerant thus useful.

	* benchtests/scripts/compare_bench.py (compare_runs): Continue instead of return.
---

diff --git a/ChangeLog b/ChangeLog
index f85b3f5fd99..18b9f37637f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-12-12  Leonardo Sandoval  <leonardo.sandoval.gonzalez@intel.com>
+
+	* benchtests/scripts/compare_bench.py (compare_runs): Continue
+	instead of return.
+
 2018-12-12  Florian Weimer  <fweimer@redhat.com>
 
 	* sysdeps/posix/timespec_get.c: Add missing “any later version”
diff --git a/benchtests/scripts/compare_bench.py b/benchtests/scripts/compare_bench.py
index f4b7742f903..9cbbda6be62 100755
--- a/benchtests/scripts/compare_bench.py
+++ b/benchtests/scripts/compare_bench.py
@@ -77,7 +77,7 @@ def compare_runs(pts1, pts2, threshold):
             # timing info for the function variant.
             if 'timings' not in pts1['functions'][func][var].keys() or \
                 'timings' not in pts2['functions'][func][var].keys():
-                    return
+                    continue
 
             # If two lists do not have the same length then it is likely that
             # the performance characteristics of the function have changed.