From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Wed, 2 Dec 2015 17:48:39 +0000 (+0000)
Subject: Try to fix SUSPICIOUS_RECIPS rule
X-Git-Tag: 1.1.0~428
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=588f6414939fa8f4116eb3dad0fa287962037e83;p=thirdparty%2Frspamd.git

Try to fix SUSPICIOUS_RECIPS rule

Issue: #437
---

diff --git a/src/libmime/mime_expressions.c b/src/libmime/mime_expressions.c
index ab685b2c0e..0bee87f4cf 100644
--- a/src/libmime/mime_expressions.c
+++ b/src/libmime/mime_expressions.c
@@ -1342,11 +1342,21 @@ rspamd_recipients_distance (struct rspamd_task *task, GArray * args,
 				/* Common name part */
 				hits++;
 			}
+#if 0
+			/* XXX: when we have a typical mail that is headed towards
+			 * several users within the same domain, then this rule
+			 * leads to a false-positive.
+			 * We actually need to match host against tld, but this is currently
+			 * too expensive.
+			 *
+			 * TODO: think about normal representation of InternetAddress shit
+			 */
 			else if (ar[i].addr && ar[j].addr &&
 				g_ascii_strcasecmp (ar[i].addr, ar[j].addr) == 0) {
 				/* Common address part, but different name */
 				hits++;
 			}
+#endif
 			total++;
 		}
 	}