From: Nick Porter Date: Mon, 29 Jan 2024 17:33:10 +0000 (+0000) Subject: Pacify coverity (CID #1587346) X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5896794af0d51279dbaaa9bb9adde71f2ac95a91;p=thirdparty%2Ffreeradius-server.git Pacify coverity (CID #1587346) --- diff --git a/src/lib/curl/base.c b/src/lib/curl/base.c index b222e787c67..4ac35d9d12c 100644 --- a/src/lib/curl/base.c +++ b/src/lib/curl/base.c @@ -265,6 +265,7 @@ static int fr_curl_init(void) ret = curl_global_init(CURL_GLOBAL_ALL); if (ret != CURLE_OK) { ERROR("CURL init returned error: %i - %s", ret, curl_easy_strerror(ret)); + error: fr_dict_autofree(curl_dict); return -1; } @@ -281,9 +282,17 @@ static int fr_curl_init(void) xlat_t *xlat; xlat = xlat_func_register(NULL, "uri.escape", fr_curl_xlat_uri_escape, FR_TYPE_STRING); + if (unlikely(!xlat)) { + ERROR("Failed registering \"uri.escape\" xlat"); + goto error; + } xlat_func_args_set(xlat, fr_curl_xlat_uri_args); xlat_func_safe_for_set(xlat, fr_curl_xlat_uri_escape); xlat = xlat_func_register(NULL, "uri.unescape", fr_curl_xlat_uri_unescape, FR_TYPE_STRING); + if (unlikely(!xlat)) { + ERROR("Failed registering \"uri.unescape\" xlat"); + goto error; + } xlat_func_args_set(xlat, fr_curl_xlat_uri_args); }