From: Mark Murawki <markm@intellasoft.net>
Date: Mon, 18 Jul 2011 12:35:57 +0000 (+0000)
Subject: If the sip private structure is null, sip_setoption() will defref the null pointer... 
X-Git-Tag: 1.8.6.0-rc1~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=58a56845a642e5436fe82dde241ccda51cd728c0;p=thirdparty%2Fasterisk.git

If the sip private structure is null, sip_setoption() will defref the null pointer and crash.

Ideally, sip_setoption shouldn't be called if there is a lack of a sip private structure.  But this will fix a crash.

(closes issue ASTERISK-17909)
Reported by: Mark Murawski
Tested by: Mark Murawski



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@328608 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 3c0a46e2d3..6ebb1b2ec9 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -4231,6 +4231,11 @@ static int sip_setoption(struct ast_channel *chan, int option, void *data, int d
 	int res = -1;
 	struct sip_pvt *p = chan->tech_pvt;
 
+        if (!p) {
+        	ast_log(LOG_ERROR, "Attempt to Ref a null pointer.  sip private structure is gone!\n");
+        	return -1;
+        }
+
 	sip_pvt_lock(p);
 
 	switch (option) {