From: Theodore Ts'o <tytso@mit.edu>
Date: Tue, 21 Dec 2010 23:05:07 +0000 (-0500)
Subject: ext2fs: fix memory leak in an error case in inode_open()
X-Git-Tag: v1.42-WIP-0702~66
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=58caabc37d696363330c390f77a901bbc81cda1e;p=thirdparty%2Fe2fsprogs.git

ext2fs: fix memory leak in an error case in inode_open()

Reported-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

diff --git a/lib/ext2fs/inode_io.c b/lib/ext2fs/inode_io.c
index 4faaa4878..b3e7ce516 100644
--- a/lib/ext2fs/inode_io.c
+++ b/lib/ext2fs/inode_io.c
@@ -163,9 +163,10 @@ static errcode_t inode_open(const char *name, int flags, io_channel *channel)
 	return 0;
 
 cleanup:
-	if (data) {
+	if (io->name)
+		ext2fs_free_mem(&io->name);
+	if (data)
 		ext2fs_free_mem(&data);
-	}
 	if (io)
 		ext2fs_free_mem(&io);
 	return retval;