From: Harshit Agarwal Date: Thu, 14 Nov 2024 21:08:11 +0000 (-0700) Subject: sched: add READ_ONCE to task_on_rq_queued X-Git-Tag: v6.14-rc1~184^2~47 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=59297e2093ceced86393a059a4bd36802311f7bb;p=thirdparty%2Fkernel%2Fstable.git sched: add READ_ONCE to task_on_rq_queued task_on_rq_queued read p->on_rq without READ_ONCE, though p->on_rq is set with WRITE_ONCE in {activate|deactivate}_task and smp_store_release in __block_task, and also read with READ_ONCE in task_on_rq_migrating. Make all of these accesses pair together by adding READ_ONCE in the task_on_rq_queued. Signed-off-by: Harshit Agarwal Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Phil Auld Link: https://lkml.kernel.org/r/20241114210812.1836587-1-jon@nutanix.com --- diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 76f5f53a645fc..0f6790c5279b3 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2271,7 +2271,7 @@ static inline int task_on_cpu(struct rq *rq, struct task_struct *p) static inline int task_on_rq_queued(struct task_struct *p) { - return p->on_rq == TASK_ON_RQ_QUEUED; + return READ_ONCE(p->on_rq) == TASK_ON_RQ_QUEUED; } static inline int task_on_rq_migrating(struct task_struct *p)