From: Jason Ish <jason.ish@oisf.net>
Date: Thu, 29 Aug 2024 20:33:42 +0000 (-0600)
Subject: tlsstore: remove ThreadExitPrintStats callback
X-Git-Tag: suricata-8.0.0-beta1~916
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=594cca77cef42e4a8f497924fb828349cddb3a5c;p=thirdparty%2Fsuricata.git

tlsstore: remove ThreadExitPrintStats callback

Remove the callback to print stats on thread exit.  The counter value
was never being used and this helps us get rid of this callback
altogether as their is only one other usage of it.

Ticket: #7227
---

diff --git a/src/log-tlsstore.c b/src/log-tlsstore.c
index e6c89559ed..4e7ed98b77 100644
--- a/src/log-tlsstore.c
+++ b/src/log-tlsstore.c
@@ -50,8 +50,6 @@ static char logging_dir_not_writable;
 #define LOGGING_WRITE_ISSUE_LIMIT 6
 
 typedef struct LogTlsStoreLogThread_ {
-    uint32_t tls_cnt;
-
     uint8_t*   enc_buf;
     size_t     enc_buf_len;
 } LogTlsStoreLogThread;
@@ -384,16 +382,6 @@ static TmEcode LogTlsStoreLogThreadDeinit(ThreadVars *t, void *data)
     return TM_ECODE_OK;
 }
 
-static void LogTlsStoreLogExitPrintStats(ThreadVars *tv, void *data)
-{
-    LogTlsStoreLogThread *aft = (LogTlsStoreLogThread *)data;
-    if (aft == NULL) {
-        return;
-    }
-
-    SCLogInfo("(%s) certificates extracted %" PRIu32 "", tv->name, aft->tls_cnt);
-}
-
 /**
  *  \internal
  *
@@ -447,14 +435,13 @@ static OutputInitResult LogTlsStoreLogInitCtx(ConfNode *conf)
 
 void LogTlsStoreRegister (void)
 {
-    OutputRegisterTxModuleWithCondition(LOGGER_TLS_STORE, MODULE_NAME,
-        "tls-store", LogTlsStoreLogInitCtx, ALPROTO_TLS, LogTlsStoreLogger,
-        LogTlsStoreCondition, LogTlsStoreLogThreadInit,
-        LogTlsStoreLogThreadDeinit, LogTlsStoreLogExitPrintStats);
+    OutputRegisterTxModuleWithCondition(LOGGER_TLS_STORE, MODULE_NAME, "tls-store",
+            LogTlsStoreLogInitCtx, ALPROTO_TLS, LogTlsStoreLogger, LogTlsStoreCondition,
+            LogTlsStoreLogThreadInit, LogTlsStoreLogThreadDeinit, NULL);
 
     OutputRegisterTxModuleWithCondition(LOGGER_TLS_STORE_CLIENT, MODULE_NAME, "tls-store",
             LogTlsStoreLogInitCtx, ALPROTO_TLS, LogTlsStoreLoggerClient, LogTlsStoreConditionClient,
-            LogTlsStoreLogThreadInit, LogTlsStoreLogThreadDeinit, LogTlsStoreLogExitPrintStats);
+            LogTlsStoreLogThreadInit, LogTlsStoreLogThreadDeinit, NULL);
 
     SC_ATOMIC_INIT(cert_id);
     SC_ATOMIC_SET(cert_id, 1);