From: Pavel Hrdina <phrdina@redhat.com>
Date: Mon, 15 Nov 2021 14:48:41 +0000 (+0100)
Subject: test: snapshot revert: drop error the VM must be restarted
X-Git-Tag: v7.10.0-rc1~50
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5956eddf9fadefa426ada80eb70722c89e1c1d59;p=thirdparty%2Flibvirt.git

test: snapshot revert: drop error the VM must be restarted

This will always happen so there is no need to error out and require
usage of FORCE flag.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 47e4d95401..e45748c5fc 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -9048,18 +9048,6 @@ testDomainRevertToSnapshot(virDomainSnapshotPtr snapshot,
         goto cleanup;
     }
 
-    if (!(flags & VIR_DOMAIN_SNAPSHOT_REVERT_FORCE)) {
-        if (virDomainObjIsActive(vm) &&
-            !(snapdef->state == VIR_DOMAIN_SNAPSHOT_RUNNING ||
-              snapdef->state == VIR_DOMAIN_SNAPSHOT_PAUSED) &&
-            (flags & (VIR_DOMAIN_SNAPSHOT_REVERT_RUNNING |
-                      VIR_DOMAIN_SNAPSHOT_REVERT_PAUSED))) {
-            virReportError(VIR_ERR_SNAPSHOT_REVERT_RISKY, "%s",
-                           _("must respawn guest to start inactive snapshot"));
-            goto cleanup;
-        }
-    }
-
     virDomainSnapshotSetCurrent(vm->snapshots, NULL);
 
     config = virDomainDefCopy(snap->def->dom,