From: W. Felix Handte <w@felixhandte.com>
Date: Mon, 12 Nov 2018 20:07:57 +0000 (-0800)
Subject: Fix #1412: Perform Signed Comparison When Setting Attach Dict Param
X-Git-Tag: v1.3.8~48^2^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=596f7d12560f8fb46edcc9ba16c0da5c791f2206;p=thirdparty%2Fzstd.git

Fix #1412: Perform Signed Comparison When Setting Attach Dict Param
---

diff --git a/lib/compress/zstd_compress.c b/lib/compress/zstd_compress.c
index 7721325d7..436522ed3 100644
--- a/lib/compress/zstd_compress.c
+++ b/lib/compress/zstd_compress.c
@@ -412,11 +412,14 @@ size_t ZSTD_CCtxParam_setParameter(
         CCtxParams->forceWindow = (value > 0);
         return CCtxParams->forceWindow;
 
-    case ZSTD_p_forceAttachDict :
-        CCtxParams->attachDictPref = value ?
-                                    (value > 0 ? ZSTD_dictForceAttach : ZSTD_dictForceCopy) :
+    case ZSTD_p_forceAttachDict : {
+        int signed_val = (int)value;
+        CCtxParams->attachDictPref = signed_val ?
+                                    (signed_val > 0 ? ZSTD_dictForceAttach :
+                                                      ZSTD_dictForceCopy) :
                                      ZSTD_dictDefaultAttach;
         return CCtxParams->attachDictPref;
+    }
 
     case ZSTD_p_nbWorkers :
 #ifndef ZSTD_MULTITHREAD