From: Jennifer Liu <jenniferliu620@fb.com>
Date: Fri, 29 Jun 2018 19:47:03 +0000 (-0700)
Subject: Fix splitPoint floating point comparison problem
X-Git-Tag: v0.0.29~69^2~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=59797d3328aab09caf5b56e2a02640c7fae2b87b;p=thirdparty%2Fzstd.git

Fix splitPoint floating point comparison problem
---

diff --git a/lib/dictBuilder/cover.c b/lib/dictBuilder/cover.c
index c03ae9a11..dbb90c1f0 100644
--- a/lib/dictBuilder/cover.c
+++ b/lib/dictBuilder/cover.c
@@ -714,9 +714,8 @@ ZDICTLIB_API size_t ZDICT_trainFromBuffer_cover(
     return ERROR(dstSize_tooSmall);
   }
   /* Initialize context and activeDmers */
-  const double all = 1.0;
   if (!COVER_ctx_init(&ctx, samplesBuffer, samplesSizes, nbSamples,
-                      parameters.d, all)) {
+                      parameters.d, parameters.splitPoint)) {
     return ERROR(GENERIC);
   }
   if (!COVER_map_init(&activeDmers, parameters.k - parameters.d + 1)) {
@@ -974,7 +973,7 @@ ZDICTLIB_API size_t ZDICT_optimizeTrainFromBuffer_cover(
   /* constants */
   const unsigned nbThreads = parameters->nbThreads;
   const double splitPoint =
-      parameters->splitPoint == 0 ? DEFAULT_SPLITPOINT : parameters->splitPoint;
+      parameters->splitPoint == 0.0 ? DEFAULT_SPLITPOINT : parameters->splitPoint;
   const unsigned kMinD = parameters->d == 0 ? 6 : parameters->d;
   const unsigned kMaxD = parameters->d == 0 ? 8 : parameters->d;
   const unsigned kMinK = parameters->k == 0 ? 50 : parameters->k;