From: Tom Peters (thopeter) Date: Fri, 18 Feb 2022 21:05:37 +0000 (+0000) Subject: Pull request #3274: mime: stop setting the file_data buffer for raw non-file MIME... X-Git-Tag: 3.1.24.0~5 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=597b6e762f9b4cbdc01d435684b87efb774d953e;p=thirdparty%2Fsnort3.git Pull request #3274: mime: stop setting the file_data buffer for raw non-file MIME parts Merge in SNORT/snort3 from ~KATHARVE/snort3:mime_file_data to master Squashed commit of the following: commit a71fc1cfe61fb6cbaa644c2dd238ff5641d63aa4 Author: Katura Harvey Date: Tue Feb 15 14:45:15 2022 -0500 mime: stop setting the file_data buffer for raw non-file MIME parts --- diff --git a/src/mime/file_mime_process.cc b/src/mime/file_mime_process.cc index 6f1750030..c31ab9098 100644 --- a/src/mime/file_mime_process.cc +++ b/src/mime/file_mime_process.cc @@ -540,11 +540,6 @@ const uint8_t* MimeSession::process_mime_data_paf( * in the body which seems more reasonable. */ } - // FIXIT-L why is this being set? we don't search file data until - // we set it again below after decoding. can it be deleted? - if ( !is_http && decode_conf && (!decode_conf->is_ignore_data())) - set_file_data(start, (end - start)); - if (data_state == STATE_DATA_HEADER) { start = process_mime_header(p, start, end);