From: Damien Miller <djm@mindrot.org>
Date: Fri, 26 Jun 2020 06:07:12 +0000 (+1000)
Subject: document a PAM spec problem in a frustrated comment
X-Git-Tag: V_8_4_P1~98
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=598c3a5e3885080ced0d7c40fde00f1d5cdbb32b;p=thirdparty%2Fopenssh-portable.git

document a PAM spec problem in a frustrated comment
---

diff --git a/auth-pam.c b/auth-pam.c
index 5a3ba09b4..832382151 100644
--- a/auth-pam.c
+++ b/auth-pam.c
@@ -375,7 +375,11 @@ import_environments(struct sshbuf *b)
 			error("PAM: pam_putenv: %s",
 			    pam_strerror(sshpam_handle, r));
 		}
-		/* XXX leak env? */
+		/*
+		 * XXX this possibly leaks env because it is not documented
+		 * what pam_putenv() does with it. Does it copy it? Does it
+		 * take ownweship? We don't know, so it's safest just to leak.
+		 */
 	}
 #endif
 }