From: John Ferlan <jferlan@redhat.com>
Date: Wed, 7 Aug 2019 13:57:46 +0000 (-0400)
Subject: tests: Fix memory leak in mymain
X-Git-Tag: v5.7.0-rc1~357
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=59a3b79506cc6921c24b8e0042c95178fec2c368;p=thirdparty%2Flibvirt.git

tests: Fix memory leak in mymain

Commit d2899a648 added a new exit path, but didn't free @fakerootdir.
Let's just use VIR_AUTOFREE instead to make life easier.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c
index 7d15a87797..20984f3442 100644
--- a/tests/virhostdevtest.c
+++ b/tests/virhostdevtest.c
@@ -556,7 +556,7 @@ static int
 mymain(void)
 {
     int ret = 0;
-    char *fakerootdir;
+    VIR_AUTOFREE(char *) fakerootdir = NULL;
 
     if (VIR_STRDUP_QUIET(fakerootdir, FAKEROOTDIRTEMPLATE) < 0) {
         fprintf(stderr, "Out of memory\n");
@@ -594,8 +594,6 @@ mymain(void)
     if (getenv("LIBVIRT_SKIP_CLEANUP") == NULL)
         virFileDeleteTree(fakerootdir);
 
-    VIR_FREE(fakerootdir);
-
     return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
 }