From: Thierry FOURNIER <tfournier@exceliance.fr>
Date: Mon, 27 Jan 2014 15:04:43 +0000 (+0100)
Subject: BUG/MEDIUM: pattern: "pat_parse_dotted_ver()" set bad expect_type.
X-Git-Tag: v1.5-dev22~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=59ad9d65939c07e5dc83332b68817a1cdcf80729;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: pattern: "pat_parse_dotted_ver()" set bad expect_type.

This is a regression introducted by the patches "MINOR: pattern: Each
pattern sets the expected input type" and "MEDIUM: acl: Last patch
change the output type". The expected value is SMP_T_CSTR in place of
SMP_T_UINT.

This bug impact all the acl using the parser "pat_parse_dotted_ver()".
The two acl are "req_ssl_ver()" and "req.ssl_ver()".

This is a recent bug, no backport is needed.
---

diff --git a/src/pattern.c b/src/pattern.c
index ce12a0e3e9..306b514b22 100644
--- a/src/pattern.c
+++ b/src/pattern.c
@@ -495,7 +495,7 @@ int pat_parse_dotted_ver(const char **text, struct pattern *pattern, enum pat_us
 		return 0;
 	}
 
-	pattern->expect_type = SMP_T_CSTR;
+	pattern->expect_type = SMP_T_UINT;
 
 	if (!last)
 		pattern->val.range.min = i;