From: Victor Julien <vjulien@oisf.net>
Date: Fri, 21 Apr 2023 08:30:37 +0000 (+0200)
Subject: decode: suppress scan-build warning
X-Git-Tag: suricata-7.0.0-rc2~369
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=59ca5cc655e1b96fe227df4ef0492b73c55c9631;p=thirdparty%2Fsuricata.git

decode: suppress scan-build warning
---

diff --git a/src/decode.c b/src/decode.c
index b3da7a1ed1..3bf8a98a5b 100644
--- a/src/decode.c
+++ b/src/decode.c
@@ -740,7 +740,7 @@ inline int PacketSetData(Packet *p, const uint8_t *pktdata, uint32_t pktlen)
 
 const char *PktSrcToString(enum PktSrcEnum pkt_src)
 {
-    const char *pkt_src_str = "<unknown>";
+    const char *pkt_src_str = NULL;
     switch (pkt_src) {
         case PKT_SRC_WIRE:
             pkt_src_str = "wire/pcap";
@@ -779,6 +779,7 @@ const char *PktSrcToString(enum PktSrcEnum pkt_src)
             pkt_src_str = "capture timeout flush";
             break;
     }
+    DEBUG_VALIDATE_BUG_ON(pkt_src_str == NULL);
     return pkt_src_str;
 }