From: William Lallemand <wlallemand@haproxy.com>
Date: Thu, 9 Nov 2023 13:08:10 +0000 (+0100)
Subject: MINOR: errors: does not check MODE_STARTING for log emission
X-Git-Tag: v2.9-dev10~117
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=59d699c0c434c68f5bbf36de49aeb92db6893cfc;p=thirdparty%2Fhaproxy.git

MINOR: errors: does not check MODE_STARTING for log emission

ha_alert(), ha_warning() and ha_notice() shouldn't check MODE_STARTING
for log emission. Let's remove the check.

This shouldn't do much since the stdio_quiet() function mute the output
in main().
---

diff --git a/src/errors.c b/src/errors.c
index bd157a82e7..8e3bc5b010 100644
--- a/src/errors.c
+++ b/src/errors.c
@@ -444,8 +444,7 @@ void ha_alert(const char *fmt, ...)
 {
 	va_list argp;
 
-	if (!(global.mode & MODE_QUIET) || (global.mode & MODE_VERBOSE) ||
-	    !(global.mode & MODE_STARTING)) {
+	if (!(global.mode & MODE_QUIET) || (global.mode & MODE_VERBOSE)) {
 		warn_exec_path();
 		va_start(argp, fmt);
 		print_message(1, "ALERT", fmt, argp);
@@ -463,8 +462,7 @@ void ha_warning(const char *fmt, ...)
 	warned |= WARN_ANY;
 	HA_ATOMIC_INC(&tot_warnings);
 
-	if (!(global.mode & MODE_QUIET) || (global.mode & MODE_VERBOSE) ||
-	    !(global.mode & MODE_STARTING)) {
+	if (!(global.mode & MODE_QUIET) || (global.mode & MODE_VERBOSE)) {
 		warn_exec_path();
 		va_start(argp, fmt);
 		print_message(1, "WARNING", fmt, argp);
@@ -515,8 +513,7 @@ void ha_notice(const char *fmt, ...)
 {
 	va_list argp;
 
-	if (!(global.mode & MODE_QUIET) || (global.mode & MODE_VERBOSE) ||
-	    !(global.mode & MODE_STARTING)) {
+	if (!(global.mode & MODE_QUIET) || (global.mode & MODE_VERBOSE)) {
 		va_start(argp, fmt);
 		print_message(1, "NOTICE", fmt, argp);
 		va_end(argp);