From: Bob Halley <halley@dnspython.org>
Date: Fri, 23 Apr 2021 22:26:33 +0000 (-0700)
Subject: Add entries to the resolution errors list in a few error cases that were omitted.
X-Git-Tag: v2.2.0rc1~92
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=59f5b365e62a37565eb7dead521d82604b208334;p=thirdparty%2Fdnspython.git

Add entries to the resolution errors list in a few error cases that were omitted.
---

diff --git a/dns/resolver.py b/dns/resolver.py
index 7bdfd91f..8d7c8056 100644
--- a/dns/resolver.py
+++ b/dns/resolver.py
@@ -663,7 +663,9 @@ class _Resolution:
             try:
                 answer = Answer(self.qname, self.rdtype, self.rdclass, response,
                                 self.nameserver, self.port)
-            except Exception:
+            except Exception as e:
+                self.errors.append((self.nameserver, self.tcp_attempt,
+                                   self.port, e, response))
                 # The nameserver is no good, take it out of the mix.
                 self.nameservers.remove(self.nameserver)
                 return (None, False)
@@ -679,7 +681,9 @@ class _Resolution:
             try:
                 answer = Answer(self.qname, dns.rdatatype.ANY,
                                 dns.rdataclass.IN, response)
-            except Exception:
+            except Exception as e:
+                self.errors.append((self.nameserver, self.tcp_attempt,
+                                   self.port, e, response))
                 # The nameserver is no good, take it out of the mix.
                 self.nameservers.remove(self.nameserver)
                 return (None, False)