From: Victor Julien <vjulien@oisf.net>
Date: Mon, 15 Apr 2024 10:29:12 +0000 (+0200)
Subject: decode/ppp: add missing types definitions
X-Git-Tag: suricata-7.0.6~63
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=59f922a134897c340db87b18efd6255fabbdaa28;p=thirdparty%2Fsuricata.git

decode/ppp: add missing types definitions

Recognize PPP_CCP, PPP_CBCP and PPP_COMP_DGRAM.

Does not implement decoders for these record types, so these
are logged as unsupported types. Was "wrong_type" before.

(cherry picked from commit 516441b6005f4200ae155f5234cfd0ad20d2dfbc)
---

diff --git a/src/decode-ppp.c b/src/decode-ppp.c
index 2e558ab5bf..1d22b25589 100644
--- a/src/decode-ppp.c
+++ b/src/decode-ppp.c
@@ -158,6 +158,9 @@ static int DecodePPPUncompressedProto(ThreadVars *tv, DecodeThreadVars *dtv, Pac
         case PPP_PAP:
         case PPP_LQM:
         case PPP_CHAP:
+        case PPP_CCP:
+        case PPP_CBCP:
+        case PPP_COMP_DGRAM:
             ENGINE_SET_EVENT(p,PPP_UNSUP_PROTO);
             return TM_ECODE_OK;
 
diff --git a/src/decode-ppp.h b/src/decode-ppp.h
index f8914cf2e7..66894b03d7 100644
--- a/src/decode-ppp.h
+++ b/src/decode-ppp.h
@@ -59,6 +59,9 @@
 #define PPP_PAP        0xc023       /* Password Authentication Protocol */
 #define PPP_LQM        0xc025       /* Link Quality Monitoring */
 #define PPP_CHAP       0xc223       /* Challenge Handshake Authentication Protocol */
+#define PPP_CCP        0x80fd       /* Compression Control Protocol */
+#define PPP_CBCP       0xc029       /* Callback Control Protocol CBCP */
+#define PPP_COMP_DGRAM 0x00fd       /* Compressed datagram */
 
 /** PPP Packet header */
 typedef struct PPPHdr_ {