From: Benoît Monin <benoit.monin@gmx.fr>
Date: Sat, 25 Apr 2015 10:02:44 +0000 (+0200)
Subject: rrdlast: fix options documentation and parsing
X-Git-Tag: v1.5.3~5^2^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a00dc4000d1e9100746613c764f7a76fba8ff89;p=thirdparty%2Frrdtool-1.x.git

rrdlast: fix options documentation and parsing

* Document short option '-d' for daemon.
* Remove noflush option from documentation, unimplemented
* Add short-option '-d' to error message.
* Add daemon to rrdtool help.
---

diff --git a/doc/rrdlast.pod b/doc/rrdlast.pod
index f0eaad0c..ab9c42a8 100644
--- a/doc/rrdlast.pod
+++ b/doc/rrdlast.pod
@@ -5,7 +5,7 @@ rrdlast - Return the date of the last data sample in an RRD
 =head1 SYNOPSIS
 
 B<rrdtool> B<last> I<filename>
-S<[B<--daemon> I<address>]>
+S<[B<--daemon>|B<-d> I<address>]>
 
 =head1 DESCRIPTION
 
@@ -18,7 +18,7 @@ update of the RRD.
 
 The name of the B<RRD> that contains the data.
 
-=item B<--daemon> I<address>
+=item B<--daemon>|B<-d> I<address>
 
 Address of the L<rrdcached> daemon. If specified, a C<flush> command is sent
 to the server before reading the RRD files. This allows B<rrdtool> to return
@@ -27,13 +27,6 @@ For a list of accepted formats, see the B<-l> option in the L<rrdcached> manual.
 
  rrdtool last --daemon unix:/var/run/rrdcached.sock /var/lib/rrd/foo.rrd
 
-=item B<--noflush> 
-
-If the L<rrdcached> daemon is being used, then omit the flush normally 
-send before returning the last update.  If you add this option, you get the 
-last time the file on disk was updated; if you have relatively low cache times
-and are calling this frequently it will preserve the caching benefit
-
 =back
 
 =head1 ENVIRONMENT VARIABLES
diff --git a/src/rrd_last.c b/src/rrd_last.c
index 30bece91..dc012a16 100644
--- a/src/rrd_last.c
+++ b/src/rrd_last.c
@@ -45,7 +45,7 @@ time_t rrd_last(
             break;
 
         default:
-            rrd_set_error ("Usage: rrdtool %s [--daemon <addr>] <file>",
+            rrd_set_error ("Usage: rrdtool %s [--daemon|-d <addr>] <file>",
                     argv[0]);
             return (-1);
             break;
@@ -53,7 +53,7 @@ time_t rrd_last(
     }                   /* while (42) */
 
     if ((argc - optind) != 1) {
-        rrd_set_error ("Usage: rrdtool %s [--daemon <addr>] <file>",
+        rrd_set_error ("Usage: rrdtool %s [--daemon|-d <addr>] <file>",
                 argv[0]);
         return (-1);
     }
diff --git a/src/rrd_tool.c b/src/rrd_tool.c
index 74d57f7d..8af96841 100644
--- a/src/rrd_tool.c
+++ b/src/rrd_tool.c
@@ -88,7 +88,8 @@ void PrintUsage(
 
     const char *help_last =
         N_("* last - show last update time for RRD\n\n"
-           "\trrdtool last filename.rrd\n");
+           "\trrdtool last filename.rrd\n"
+           "\t\t[--daemon|-d address]\n");
 
     const char *help_lastupdate =
         N_("* lastupdate - returns the most recent datum stored for\n"