From: Alan T. DeKok <aland@freeradius.org>
Date: Sat, 11 Jan 2025 15:04:01 +0000 (-0500)
Subject: tweak code to satisfy coverity #1633838
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a2bdccba3d87ef07d1825e678e8b9a5f4f297cd;p=thirdparty%2Ffreeradius-server.git

tweak code to satisfy coverity #1633838
---

diff --git a/src/protocols/radius/encode.c b/src/protocols/radius/encode.c
index 9656d434fa7..e4b0151a1d6 100644
--- a/src/protocols/radius/encode.c
+++ b/src/protocols/radius/encode.c
@@ -331,7 +331,6 @@ static ssize_t encode_value(fr_dbuff_t *dbuff,
 	fr_dbuff_t			value_dbuff;
 	fr_dbuff_marker_t		value_start, src, dest;
 	bool				encrypted = false;
-	fr_radius_attr_flags_encrypt_t	encrypt;
 
 	PAIR_VERIFY(vp);
 	FR_PROTO_STACK_PRINT(da_stack, depth);
@@ -493,8 +492,7 @@ static ssize_t encode_value(fr_dbuff_t *dbuff,
 	 *	Attributes with encrypted values MUST be less than
 	 *	128 bytes long.
 	 */
-	encrypt = fr_radius_flag_encrypted(da);
-	if (encrypt) switch (encrypt) {
+	switch (fr_radius_flag_encrypted(da)) {
 	case RADIUS_FLAG_ENCRYPT_USER_PASSWORD:
 		/*
 		 *	Encode the password in place