From: Guillem Jover <guillem@hadrons.org>
Date: Sun, 7 Feb 2016 01:47:22 +0000 (+0100)
Subject: Fix unportable sizeof() usage
X-Git-Tag: 0.8.3~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a32ea0a72ba9fa4275080a2a51612ae50f66dd3;p=thirdparty%2Flibbsd.git

Fix unportable sizeof() usage

We are calculating the size of the array, and need to pass the size of
each element, not the size of a pointer to an element. Although this
happens to be the same in many cases, this is not a portable assumption.

Warned-by: coverity
---

diff --git a/src/radixsort.c b/src/radixsort.c
index 1473925..ad2ae70 100644
--- a/src/radixsort.c
+++ b/src/radixsort.c
@@ -118,7 +118,7 @@ sradixsort(const u_char **a, int n, const u_char *tab, u_int endch)
 	if (n < THRESHOLD)
 		simplesort(a, n, 0, tr, endch);
 	else {
-		ta = reallocarray(NULL, n, sizeof(a));
+		ta = reallocarray(NULL, n, sizeof(*a));
 		if (ta == NULL)
 			return (-1);
 		r_sort_b(a, ta, n, 0, tr, endch);