From: Francis Dupont <fdupont@isc.org>
Date: Thu, 26 Sep 2019 13:12:04 +0000 (+0200)
Subject: [907-remove-kea-thread-library] Addressed comments
X-Git-Tag: tmark-pre-35~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a36558f35edc0d55bb1d9bd88fa8deda3373c53;p=thirdparty%2Fkea.git

[907-remove-kea-thread-library] Addressed comments
---

diff --git a/doc/devel/Doxyfile b/doc/devel/Doxyfile
index c3960acffd..5032a88325 100644
--- a/doc/devel/Doxyfile
+++ b/doc/devel/Doxyfile
@@ -814,7 +814,6 @@ INPUT                  = ../../src/bin/agent \
                          ../../src/lib/util/encode \
                          ../../src/lib/util/io \
                          ../../src/lib/util/random \
-                         ../../src/lib/util/threads \
                          ../../src/lib/util/unittests \
                          ../../src/lib/yang \
                          .
diff --git a/doc/devel/congestion-handling.dox b/doc/devel/congestion-handling.dox
index 058a3a7f41..e5e44fe815 100644
--- a/doc/devel/congestion-handling.dox
+++ b/doc/devel/congestion-handling.dox
@@ -1,4 +1,4 @@
-// Copyright (C) 2018 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2018-2019 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -111,8 +111,7 @@ isc::dhcp::PacketQueueRing6).  The most critical aspects to remember when
 developing your implementation are:
 
 -# It MUST be thread safe since queuing and dequeing packets are done by
-separate threads. (You might considering using isc::util::thread::Mutex and
-isc::util::thread::Mutex::Locker).
+separate threads. (You might considering using std::mutex and std::lock_guard).
 
 -# Its efficiency (or lack thereof) will have a direct impact on server
 performance.  You will have to consider the dynamics of your deployment
diff --git a/src/hooks/dhcp/high_availability/tests/ha_test.h b/src/hooks/dhcp/high_availability/tests/ha_test.h
index 169a7281d3..ab1487f1cf 100644
--- a/src/hooks/dhcp/high_availability/tests/ha_test.h
+++ b/src/hooks/dhcp/high_availability/tests/ha_test.h
@@ -22,6 +22,7 @@
 #include <string>
 #include <vector>
 #include <mutex>
+#include <condition_variable>
 #include <thread>
 
 namespace isc {
diff --git a/src/lib/testutils/threaded_test.h b/src/lib/testutils/threaded_test.h
index 1ff4909c2e..7b0a972871 100644
--- a/src/lib/testutils/threaded_test.h
+++ b/src/lib/testutils/threaded_test.h
@@ -11,6 +11,7 @@
 #include <gtest/gtest.h>
 #include <thread>
 #include <mutex>
+#include <condition_variable>
 
 namespace isc {
 namespace test {