From: William A. Rowe Jr <wrowe@apache.org>
Date: Mon, 14 Oct 2002 00:12:02 +0000 (+0000)
Subject:   A couple of observations
X-Git-Tag: 2.0.44~295
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a3e3f0e54fbfaf74287eab2d8af2cddf16fcf9b;p=thirdparty%2Fapache%2Fhttpd.git

  A couple of observations


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97199 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/arch/netware/mod_nw_ssl.c b/modules/arch/netware/mod_nw_ssl.c
index bbb0b5678e5..c474812f566 100644
--- a/modules/arch/netware/mod_nw_ssl.c
+++ b/modules/arch/netware/mod_nw_ssl.c
@@ -147,6 +147,9 @@ static unsigned long parse_addr(const char *w, unsigned short *ports)
     hep = gethostbyname(w);
 
     if ((!hep) || (hep->h_addrtype != AF_INET || !hep->h_addr_list[0])) {
+        /* XXX Should be echoing by r_errno the actual failure, no? 
+         * ap_log_error would be good here.
+         */
         fprintf(stderr, "Cannot resolve host name %s --- exiting!\n", w);
         exit(1);
     }
diff --git a/server/util.c b/server/util.c
index f0aabab1125..166dec82aba 100644
--- a/server/util.c
+++ b/server/util.c
@@ -1837,6 +1837,7 @@ char *ap_get_local_host(apr_pool_t *a)
     else 
     {
         str[sizeof(str) - 1] = '\0';
+        /* TODO: Screaming for APR-ization */
         if ((!(p = gethostbyname(str))) 
             || (!(server_hostname = find_fqdn(a, p)))) {
             /* Recovery - return the default servername by IP: */