From: Michał Kępień <michal@isc.org>
Date: Fri, 7 Aug 2020 12:35:05 +0000 (+0200)
Subject: Do not run "make recheck" if the test suite fails
X-Git-Tag: v9.17.5~62^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a4076fc407a8dd3daf7f884833d3c4b553fb195;p=thirdparty%2Fbind9.git

Do not run "make recheck" if the test suite fails

Running "make recheck" after the test suite fails hides intermittent
system test failures in GitLab CI.  This makes it hard to identify which
branches are affected by a particular test failure mode and causes CI
results to be overly optimistic.  Prevent "make recheck" from being run
when "make check" fails to ensure GitLab CI results properly reflect the
stability of the "main" branch.
---

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 6b5b422828f..178dc5d0fbc 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -248,7 +248,7 @@ stages:
     - *setup_softhsm
   script:
     - cd bin/tests/system
-    - make -j${TEST_PARALLEL_JOBS:-1} -k check V=1 || make -j${TEST_PARALLEL_JOBS:-1} -k recheck V=1
+    - make -j${TEST_PARALLEL_JOBS:-1} -k check V=1
   after_script:
     - cat bin/tests/system/test-suite.log