From: Stephen Hemminger Date: Mon, 7 Aug 2006 23:36:02 +0000 (-0700) Subject: ipx: header length validation needed X-Git-Tag: v2.6.17.11~13 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a4ceb2adfc3f7d35fa07420582f626c8402e605;p=thirdparty%2Fkernel%2Fstable.git ipx: header length validation needed This patch will linearize and check there is enough data. It handles the pprop case as well as avoiding a whole audit of the routing code. Signed-off-by: Stephen Hemminger --- diff --git a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c index 811d998725bc6..e6a50e82603b9 100644 --- a/net/ipx/af_ipx.c +++ b/net/ipx/af_ipx.c @@ -1647,7 +1647,8 @@ static int ipx_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_ty ipx_pktsize = ntohs(ipx->ipx_pktsize); /* Too small or invalid header? */ - if (ipx_pktsize < sizeof(struct ipxhdr) || ipx_pktsize > skb->len) + if (ipx_pktsize < sizeof(struct ipxhdr) + || !pskb_may_pull(skb, ipx_pktsize)) goto drop; if (ipx->ipx_checksum != IPX_NO_CHECKSUM &&