From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Wed, 7 Apr 2021 13:36:12 +0000 (+0900)
Subject: udev: fix potential infinite loop
X-Git-Tag: v249-rc1~461^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a6e56ec1703e84f7860152e483da816ca4b1cbb;p=thirdparty%2Fsystemd.git

udev: fix potential infinite loop
---

diff --git a/src/udev/udev-builtin-net_id.c b/src/udev/udev-builtin-net_id.c
index f4b200ea423..f84c2669a85 100644
--- a/src/udev/udev-builtin-net_id.c
+++ b/src/udev/udev-builtin-net_id.c
@@ -395,8 +395,9 @@ static int dev_pci_slot(sd_device *dev, struct netnames *names) {
                         break;
                 }
 
-                if (sd_device_get_sysname(hotplug_slot_dev, &sysname) < 0)
-                        continue;
+                r = sd_device_get_sysname(hotplug_slot_dev, &sysname);
+                if (r < 0)
+                        return log_device_debug_errno(hotplug_slot_dev, r, "Failed to get sysname: %m");
 
                 FOREACH_DIRENT_ALL(dent, dir, break) {
                         _cleanup_free_ char *address = NULL;