From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Thu, 18 Jan 2018 22:08:30 +0000 (+0100)
Subject: codewriter: Don't use string.replace() to apply header_to_override
X-Git-Tag: 0.39.5~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a7300d6f40acb650c45b545ad14e0524e0b6dd7;p=thirdparty%2Fvala.git

codewriter: Don't use string.replace() to apply header_to_override

The underlying regex causes faulty replacements.

https://bugzilla.gnome.org/show_bug.cgi?id=731322
---

diff --git a/vala/valacodewriter.vala b/vala/valacodewriter.vala
index 8c0e68804..2fed2d8f5 100644
--- a/vala/valacodewriter.vala
+++ b/vala/valacodewriter.vala
@@ -214,7 +214,13 @@ public class Vala.CodeWriter : CodeVisitor {
 			}
 
 			if (header_to_override != null) {
-				cheaders = cheaders.replace (header_to_override, override_header).replace (",,", ",");
+				var cheaders_array = cheaders.split (",");
+				for (int i = 0; i < cheaders_array.length; i++) {
+					if (cheaders_array[i] == header_to_override) {
+						cheaders_array[i] = override_header;
+					}
+				}
+				cheaders = string.joinv (",", cheaders_array);
 			}
 		}
 		return cheaders;