From: Chris Rienzo <chris@signalwire.com>
Date: Sun, 16 May 2021 23:12:28 +0000 (+0000)
Subject: [core] Fix read of uninitialized buffer in switch_simple_email().
X-Git-Tag: v1.10.7^2~322^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a9eabca8e085451c259ea06c580aae74753fe15;p=thirdparty%2Ffreeswitch.git

[core] Fix read of uninitialized buffer in switch_simple_email().
---

diff --git a/src/switch_utils.c b/src/switch_utils.c
index 0fee81551b..85e12f0488 100644
--- a/src/switch_utils.c
+++ b/src/switch_utils.c
@@ -1128,6 +1128,8 @@ SWITCH_DECLARE(switch_bool_t) switch_simple_email(const char *to,
 	switch_bool_t rval = SWITCH_FALSE;
 	const char *err = NULL;
 
+	filename[0] = '\0';
+
 	if (zstr(to)) {
 		err = "No to address specified";
 		goto end;
@@ -1323,7 +1325,7 @@ SWITCH_DECLARE(switch_bool_t) switch_simple_email(const char *to,
 		close(fd);
 	}
 
-	if (unlink(filename) != 0) {
+	if (!zstr_buf(filename) && unlink(filename) != 0) {
 		switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_WARNING, "Failed to delete file [%s]\n", filename);
 	}