From: Frédéric Buclin <LpSolit@gmail.com>
Date: Mon, 14 Oct 2013 12:44:24 +0000 (+0200)
Subject: Backout 1st part of bug 340160: state $sth doesn't work fine with mod_perl
X-Git-Tag: bugzilla-4.5.1~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ab9af110e4bb7fc406b2cdcf97fd22cb265b592;p=thirdparty%2Fbugzilla.git

Backout 1st part of bug 340160: state $sth doesn't work fine with mod_perl
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 2c0d458e73..61731c0398 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -3954,11 +3954,7 @@ sub get_activity {
 # Update the bugs_activity table to reflect changes made in bugs.
 sub LogActivityEntry {
     my ($i, $col, $removed, $added, $whoid, $timestamp, $comment_id) = @_;
-    state $sth =
-      Bugzilla->dbh->prepare('INSERT INTO bugs_activity
-                              (bug_id, who, bug_when, fieldid, removed, added, comment_id)
-                              VALUES (?, ?, ?, ?, ?, ?, ?)');
-
+    my $dbh = Bugzilla->dbh;
     # in the case of CCs, deps, and keywords, there's a possibility that someone
     # might try to add or remove a lot of them at once, which might take more
     # space than the activity table allows.  We'll solve this by splitting it
@@ -3982,7 +3978,10 @@ sub LogActivityEntry {
         trick_taint($addstr);
         trick_taint($removestr);
         my $fieldid = get_field_id($col);
-        $sth->execute($i, $whoid, $timestamp, $fieldid, $removestr, $addstr, $comment_id);
+        $dbh->do("INSERT INTO bugs_activity
+                  (bug_id, who, bug_when, fieldid, removed, added, comment_id)
+                  VALUES (?, ?, ?, ?, ?, ?, ?)",
+                  undef, ($i, $whoid, $timestamp, $fieldid, $removestr, $addstr, $comment_id));
     }
 }