From: Petr Viktorin <encukou@gmail.com>
Date: Fri, 14 Nov 2025 10:22:18 +0000 (+0100)
Subject: gh-141376: Remove exceptions from `make smelly` (GH-141392)
X-Git-Tag: v3.15.0a2~46
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ac0b55ebc792936184f8e08697e60d5b3f8b946;p=thirdparty%2FPython%2Fcpython.git

gh-141376: Remove exceptions from `make smelly` (GH-141392)

* Don't ignore initialized data and BSS
* Remove exceptions for _init and _fini
---

diff --git a/Tools/build/smelly.py b/Tools/build/smelly.py
index 9a360412a73a..424fa6ad4a13 100755
--- a/Tools/build/smelly.py
+++ b/Tools/build/smelly.py
@@ -21,8 +21,6 @@ EXCEPTIONS = frozenset({
 })
 
 IGNORED_EXTENSION = "_ctypes_test"
-# Ignore constructor and destructor functions
-IGNORED_SYMBOLS = {'_init', '_fini'}
 
 
 def is_local_symbol_type(symtype):
@@ -34,19 +32,12 @@ def is_local_symbol_type(symtype):
     if symtype.islower() and symtype not in "uvw":
         return True
 
-    # Ignore the initialized data section (d and D) and the BSS data
-    # section. For example, ignore "__bss_start (type: B)"
-    # and "_edata (type: D)".
-    if symtype in "bBdD":
-        return True
-
     return False
 
 
 def get_exported_symbols(library, dynamic=False):
     print(f"Check that {library} only exports symbols starting with Py or _Py")
 
-    # Only look at dynamic symbols
     args = ['nm', '--no-sort']
     if dynamic:
         args.append('--dynamic')
@@ -89,8 +80,6 @@ def get_smelly_symbols(stdout, dynamic=False):
 
         if is_local_symbol_type(symtype):
             local_symbols.append(result)
-        elif symbol in IGNORED_SYMBOLS:
-            local_symbols.append(result)
         else:
             smelly_symbols.append(result)