From: Michael Jerris <mike@jerris.com>
Date: Mon, 24 Mar 2014 20:09:21 +0000 (-0400)
Subject: FS-5845: don't leak dbh in error conditions
X-Git-Tag: v1.5.12~318
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ac9748827e68b6c83f2cf858377ccaae691f166;p=thirdparty%2Ffreeswitch.git

FS-5845: don't leak dbh in error conditions
---

diff --git a/src/mod/applications/mod_lcr/mod_lcr.c b/src/mod/applications/mod_lcr/mod_lcr.c
index 65b4378f39..8ca25e69cd 100644
--- a/src/mod/applications/mod_lcr/mod_lcr.c
+++ b/src/mod/applications/mod_lcr/mod_lcr.c
@@ -1171,7 +1171,7 @@ static switch_status_t lcr_load_config()
 						if (db_check("ALTER TABLE carrier_gateway add codec varchar(255);") == SWITCH_TRUE) {
 							switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_NOTICE, "adding codec field your lcr carrier_gateway database schema.\n");
 						} else {
-							return SWITCH_STATUS_FALSE;
+							switch_goto_status(SWITCH_STATUS_FALSE, done);
 						}
 					}
 
@@ -1182,7 +1182,7 @@ static switch_status_t lcr_load_config()
 						if (db_check("ALTER TABLE lcr add cid varchar(32);") == SWITCH_TRUE) {
 							switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_WARNING, "adding cid field to your lcr database schema.\n");
 						} else {
-							return SWITCH_STATUS_FALSE;
+							switch_goto_status(SWITCH_STATUS_FALSE, done);
 						}
 					}
 
@@ -1190,7 +1190,7 @@ static switch_status_t lcr_load_config()
 						if (db_check("ALTER TABLE lcr ADD lrn BOOLEAN NOT NULL DEFAULT false")) {
 							switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_WARNING, "adding lrn field to your lcr database schema.\n");
 						} else {
-							return SWITCH_STATUS_FALSE;
+							switch_goto_status(SWITCH_STATUS_FALSE, done);
 						}
 					}