From: John Ferlan <jferlan@redhat.com>
Date: Fri, 21 Jun 2019 17:07:15 +0000 (-0400)
Subject: cpu_x86: Fix memory leak - virCPUx86GetHost
X-Git-Tag: v5.5.0-rc1~37
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5acb4eede23bcd5bc75193ea21542e0fb04b6e45;p=thirdparty%2Flibvirt.git

cpu_x86: Fix memory leak - virCPUx86GetHost

Commit 56b254dcc called virCPUx86DataAdd, but returned -1 directly
without calling the virCPUx86DataFree.

Found by Coverity.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 71fc365139..978a60c90a 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -2791,7 +2791,7 @@ virCPUx86GetHost(virCPUDefPtr cpu,
             };
 
             if (virCPUx86DataAdd(cpuData, &item) < 0)
-                return -1;
+                goto cleanup;
         }
     }