From: John Ferlan <jferlan@redhat.com>
Date: Mon, 20 Feb 2017 19:03:07 +0000 (-0500)
Subject: conf: Fix leak in virNodeDeviceObjListExport
X-Git-Tag: CVE-2017-2635~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ad03b9db2186d5b1d09f33e5ab0daa683054675;p=thirdparty%2Flibvirt.git

conf: Fix leak in virNodeDeviceObjListExport

Fix a leak introduced by 4337bc57b when VIR_STRDUP'g the parent.
---

diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 1c81b48053..c80284017d 100644
--- a/src/conf/node_device_conf.c
+++ b/src/conf/node_device_conf.c
@@ -2288,6 +2288,7 @@ virNodeDeviceObjListExport(virConnectPtr conn,
             if (devices) {
                 if (!(device = virGetNodeDevice(conn, devobj->def->name)) ||
                     VIR_STRDUP(device->parent, devobj->def->parent) < 0) {
+                    virObjectUnref(device);
                     virNodeDeviceObjUnlock(devobj);
                     goto cleanup;
                 }