From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 31 May 2017 17:02:43 +0000 (-0400)
Subject: stupid coverity
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ae2e13367f38ccc374902a5ab337f740e977cdb;p=thirdparty%2Ffreeradius-server.git

stupid coverity

doesn't realize that returning in a failure case with the mutex
unlocked, means that the mutex is unlocked

CID #1206498
---

diff --git a/src/modules/rlm_sql/sql.c b/src/modules/rlm_sql/sql.c
index 6e21c3bdc11..dc4eea7640e 100644
--- a/src/modules/rlm_sql/sql.c
+++ b/src/modules/rlm_sql/sql.c
@@ -545,6 +545,7 @@ void rlm_sql_query_log(rlm_sql_t const *inst, REQUEST *request, sql_acct_section
 		ERROR("Couldn't open logfile '%s': %s", expanded, fr_syserror(errno));
 
 		talloc_free(expanded);
+		/* coverity[missing_unlock] */
 		return;
 	}