From: Jan Safranek <jsafrane@redhat.com>
Date: Tue, 1 Mar 2011 12:11:35 +0000 (+0100)
Subject: Fix buffer overflow when processing list of controllers from command line (CVE-2011... 
X-Git-Tag: v0.37.1~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ae8aea1ecd60c439121d3329d8eaabf13d292c1;p=thirdparty%2Flibcgroup.git

Fix buffer overflow when processing list of controllers from command line (CVE-2011-1006).

Thanks to Nelson Elhage for reporting this issue.

Signed-off-by: Jan Safranek <jsafrane@redhat.com>
---

diff --git a/src/tools/tools-common.c b/src/tools/tools-common.c
index 4beffcd3..7d633be4 100644
--- a/src/tools/tools-common.c
+++ b/src/tools/tools-common.c
@@ -79,7 +79,7 @@ int parse_cgroup_spec(struct cgroup_group_spec **cdptr, char *optarg,
 			}
 		}
 		j++;
-	} while (temp);
+	} while (temp && j<CG_CONTROLLER_MAX-1);
 
 	/* Store path to the cgroup */
 	strncpy(cdptr[i]->path, pathptr, FILENAME_MAX);