From: Victor Julien <victor@inliniac.net>
Date: Tue, 20 Nov 2018 11:31:01 +0000 (+0100)
Subject: prelude: fix potential uninitialized value use
X-Git-Tag: suricata-4.1.1~50
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5aef72efd13d9d439037b5970542da6857f4f2da;p=thirdparty%2Fsuricata.git

prelude: fix potential uninitialized value use
---

diff --git a/src/alert-prelude.c b/src/alert-prelude.c
index 288487245a..b26ac4754c 100644
--- a/src/alert-prelude.c
+++ b/src/alert-prelude.c
@@ -628,13 +628,15 @@ static int PacketToDataV6(const Packet *p, const PacketAlert *pa, idmef_alert_t
  * \param alert IDMEF alert
  * \return 0 if ok
  */
-static int JsonToAdditionalData(const char * key, json_t * value, idmef_alert_t *alert) {
-    int ret;
+static int JsonToAdditionalData(const char * key, json_t * value, idmef_alert_t *alert)
+{
+    SCEnter();
+
+    int ret = 0;
     const char *key_js;
     char local_key[128];
     json_t *value_js;
     size_t index;
-    SCEnter();
 
     if (!json_is_object(value) && key == NULL)
         SCReturnInt(-1);