From: Victor Julien <victor@inliniac.net>
Date: Mon, 10 Jul 2017 12:33:09 +0000 (+0200)
Subject: stream: don't reset state on syn/ack resend
X-Git-Tag: suricata-4.0.0-rc2~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5afe1a981472b4807d14924be465c33ea8937b16;p=thirdparty%2Fsuricata.git

stream: don't reset state on syn/ack resend

Bug #1958.

The reset was originally created for issue #523, but that works
well without the reset as well.
---

diff --git a/src/stream-tcp.c b/src/stream-tcp.c
index 4c2dc44e7f..c43331d982 100644
--- a/src/stream-tcp.c
+++ b/src/stream-tcp.c
@@ -2444,10 +2444,6 @@ static int StreamTcpPacketStateEstablished(ThreadVars *tv, Packet *p,
 
         SCLogDebug("ssn %p: SYN/ACK packet on state ESTABLISHED... resent. "
                 "Likely due server not receiving final ACK in 3whs", ssn);
-
-        /* resetting state to TCP_SYN_RECV as we should get another ACK now */
-        StreamTcpPacketSetState(p, ssn, TCP_SYN_RECV);
-        SCLogDebug("ssn %p: =~ ssn state is now reset to TCP_SYN_RECV", ssn);
         return 0;
 
     } else if (p->tcph->th_flags & TH_SYN) {